-
Notifications
You must be signed in to change notification settings - Fork 5k
Update start.sh #2147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update start.sh #2147
Conversation
- the codes cds into its folder which makes it possible to run script from any directory - saves the return code from previous commands to a variable and returns it at exit. Without saving the exit code into a variable exit $? return the return code of the echo statement which is always 0.
@microsoft-github-policy-service agree |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See inline comment: please make similar change to ps1 and add a comment to clarify the first line. Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, I tested out both the sh and ps1 from the root and they both seemed to work. Thank you!
the codes cds into its folder which makes it possible to run script from any directory
saves the return code from previous commands to a variable and returns it at exit. Without saving the exit code into a variable exit $? return the return code of the echo statement which is always 0.
Purpose
The script's return code is always 0 even if error occurs, it fixes that. Second the users will be not required to cd in /out of the folder.
Does this introduce a breaking change?
When developers merge from main and run the server, azd up, or azd deploy, will this produce an error?
If you're not sure, try it out on an old environment.
Does this require changes to learn.microsoft.com docs?
This repository is referenced by this tutorial
which includes deployment, settings and usage instructions. If text or screenshot need to change in the tutorial,
check the box below and notify the tutorial author. A Microsoft employee can do this for you if you're an external contributor.
Type of change
Code quality checklist
See CONTRIBUTING.md for more details.
python -m pytest
).python -m pytest --cov
to verify 100% coverage of added linespython -m mypy
to check for type errorsruff
andblack
manually on my code.